Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect types for inlineHookApi #406

Open
eatplaysleep opened this issue Jan 20, 2024 · 1 comment
Open

Incorrect types for inlineHookApi #406

eatplaysleep opened this issue Jan 20, 2024 · 1 comment
Labels

Comments

@eatplaysleep
Copy link

Describe the bug

Expected types (as an example):

	interface InlineHook {
		channel: InlineHookChannelObject;
		created: Date;
		id: string;
		lastUpdated: Date;
		name: string;
		status: InlineHookStatus;
		type: InlineHookType;
		version: string;
		_links?: Record<string, any>;
                ...
	}

	interface InlineHookChannelObject {
		type: 'HTTP' | 'OAUTH';
		version: string;
		config: InlineHookHTTPConfig | InlineHookOAuthConfig;
	}

	interface InlineHookHTTPConfig {
		uri: string;
		headers?: Record<string, string>;
		authScheme: InlineHookAuthScheme
	}

	interface InlineHookOAuthConfig {
		uri: string;
		headers?: Record<string, string>;
		method: 'POST';
		authType: 'client_secret_post' | 'private_key_jwt';
	}

	interface InlineHookAuthScheme {
		type: string;
		key: string;
		value: string;
	}

Actual types:

export declare class InlineHook {
  'channel'?: InlineHookChannel;
  'created'?: Date;
  'id'?: string;
  'lastUpdated'?: Date;
  'name'?: string;
  'status'?: InlineHookStatus;
  'type'?: InlineHookType;
  'version'?: string;
  '_links'?: {
        [key: string]: any;
  };
  ...
};

export declare class InlineHookChannel {
  'type'?: InlineHookChannelType;
  'version'?: string;
  ...
}

Reproduction Steps?

use the client.inlineHookApi.xxxInlineHook() method(s).

SDK Versions

7.0.1

Additional Information

No response

@eatplaysleep
Copy link
Author

Also...

Expected:

export declare type InlineHookType = 'com.okta.import.transform' | 'com.okta.oauth2.tokens.transform' | 'com.okta.saml.tokens.transform' | 'com.okta.user.credential.password.import' | 'com.okta.user.pre-registration' |'com.okta.telephony.provider';

Actual:

export declare type InlineHookType = 'com.okta.import.transform' | 'com.okta.oauth2.tokens.transform' | 'com.okta.saml.tokens.transform' | 'com.okta.user.credential.password.import' | 'com.okta.user.pre-registration';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant