Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Spring 6 #794

Closed
clementdenis opened this issue Jan 3, 2023 · 5 comments
Closed

Compatibility with Spring 6 #794

clementdenis opened this issue Jan 3, 2023 · 5 comments

Comments

@clementdenis
Copy link
Contributor

Describe the feature request?

It's currently not possible to run the SDK in a Spring 6 / Spring Boot 3 application, due to incompatible code and HTTP client dependencies.

I've fixed the issue in my own branch (PR here), but I won't submit it as you probably want to retain Spring 5 compatibility somehow, which isn't the case here.
Also, it might be better to wait for a new version of the OpenAPI generator that supports Spring 6 (it should be fixed by there), to avoid customizing the handlebars templates as I did.

New or Affected Resource(s)

All

Provide a documentation link

No response

Additional Information?

No response

@arvindkrishnakumar-okta
Copy link
Contributor

arvindkrishnakumar-okta commented Jun 13, 2023

With SDK release 11.0.0, we've moved away from Spring Boot (2.x) and Spring 5 dependencies.

In this effort, we've replaced Spring Rest Template with Apache HttpClient5.

Therefore, compatibility with Spring should no longer be an issue.

Let me know if that helps!

@clementdenis
Copy link
Contributor Author

clementdenis commented Jun 13, 2023

Hi @arvindkrishnakumar-okta ,

It's definitely a good move to depend on a lower-level API than Spring for the generated client.
The other good news is that the auto-pagination is gone (related to #863).
But the list*WithPaginationInfo methods are also gone, which means we can't paginate at all with this version ...
Should I open a new ticket for this?

Also, the main exception type ResourceException was changed to ApiException, which is now a checked exception => is there a good reason for that? This is a major disruption to existing code bases, especially when using lambda extensively (which I do). It's something that should be at least mentioned in the migration guide.

PS: couldn't you release alpha / beta version of the client to fix this kind of major issues before releasing the first "GA" version? I'll be willing to test this early versions.

@arvindkrishnakumar-okta
Copy link
Contributor

arvindkrishnakumar-okta commented Jun 13, 2023

@clementdenis Thanks for your feedback!

We definitely considered a alpha/beta version initially but later decided to go with a GA version per internal product guidelines.

I'll work on getting more details into the migration guide/changelog to be as helpful as possible.

Meanwhile, please try out the SDK and I'd be happy to hear more feedback.

And, feel free to close this issue if you don't have any followups on this particular issue.

@clementdenis
Copy link
Contributor Author

As mentioned before, I've tried it, but definitely can't use it until pagination is back ...

@arvindkrishnakumar-okta
Copy link
Contributor

Will mark this issue resolved, pagination will be addressed in #884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants