Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings for [email protected]+ under StrictMode #57

Open
franklixuefei opened this issue Nov 12, 2018 · 2 comments
Open

Comments

@franklixuefei
Copy link
Contributor

Under StrictMode with [email protected]+, I saw the following deprecation warning:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of ContainerDimensions which is inside StrictMode. Instead, add a ref directly to the element you want to reference.

Could you fix this?

Thanks

@okonet
Copy link
Owner

okonet commented Nov 13, 2018

No, I could not. If you want you can fix it yourself and submit a PR. Thanks!

@franklixuefei
Copy link
Contributor Author

I tried. No luck. Explicitly passing ref to the children is too much work for users. I think findDOMNode() is a good usage here, despite it was deprecated in strict mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants