better logging for js config errors #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change javascript config files that had compilation errors or that threw their own errors wouldn't report the error, making debugging a mite more difficult than it should be: instead you'd get a useless "TypeError: Cannot read property 'errors' of undefined" message. Now if the javascript config file tosses its cookies for whatever reason we can read what that reason was.
okonet
approved these changes
Dec 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 609 611 +2
Branches 143 144 +1
=========================================
+ Hits 609 611 +2
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 10.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 12, 2021
chore(deps-dev): bump lint-staged from 8.1.7 to 10.5.4 in /webapps
marcus-nl/camunda-bpm-platform#14
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the original PR #915