confusion with file patterns

[rodneyrehm]

My package.json looks as follows:

{
  "scripts": {
    "lint-staged": "lint-staged"
  },
  "pre-commit": "lint-staged",
  "lint-staged": {
    "*.js": "eslint",
    "src/**/*.js": "eslint"
  },
}

My directory structure looks as follows:

├── .git
├── package.json
├── alpha.js                          [should match "*.js"]
├── src
    └── bravo
        └── charlie.js                [should match "src/**/*.js"]

I'm trying to commit alpha.js and src/bravo/charlie.js and expect both patterns given in lint-staged to each match one pattern, considering everything is relative to CWD. However neither matches.

If I prefix the patterns with **/ the files are matched. That's because the paths handed to minimatch are made absolute based on gitDir but not made relative against CWD again. The test suggests this is an oversight, or the test is mislabeled.

lint-staged v3.2.4
node v7.3.0
npm v3.10.10

---

my linters are engaged properly, if I replace the resolvePaths.js with the following:

module.exports = function resolvePaths(filePaths, relativeTo) {
    const cwd = process.cwd()
    const base = relativeTo || cwd
    return filePaths.map(file => path.relative(cwd, path.resolve(base, file.filename)))
}

[okonet]

This is probably a regression. Could you create a PR with the suggested change please? We should add tests for absolute and relative paths.

[rodneyrehm]

sure, #116 contains the fix and adapted tests.