-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test/spec] Add test cases for unset, localvar and tempenv. #718
[test/spec] Add test cases for unset, localvar and tempenv. #718
Conversation
Wow this is very comprehensive. I was thinking this file is more for idioms in real code, not synthetic test cases, but if you think it will come in handy it's OK. However I did notice some failures on ash? Do you have this version?
The errors are in cases 14 and 15:
|
For case 14 it says this:
|
Oh, really. I'm using the same version... [murase@chatoyancy 1 oilshell.oil]$ _deps/spec-bin/busybox
BusyBox v1.31.1 (2020-03-19 18:41:37 JST) multi-call binary.
BusyBox is copyrighted by many authors between 1998-2015.
Licensed under GPLv2. See source distribution for detailed
copyright notices.
(snip) The output of test case 14 from my ash:
The output of test case 15 from my ash:
Can you test the following command? $ _deps/spec-bin/busybox sh -c 'fn() { local v; echo "v: ${v-(unset)}"; }; v=global; fn'
v: (unset) My system is Fedora 30 [murase@chatoyancy 1 oilshell.oil]$ uname -a
Linux chatoyancy 5.1.20-300.fc30.x86_64 #1 SMP Fri Jul 26 15:03:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
[murase@chatoyancy 1 oilshell.oil]$ cat /etc/redhat-release
Fedora release 30 (Thirty) |
OK! I created I tried this command also with Linux busybox 1.28.3, Cygwin busybox 1.23.2, FreeBSD busybox 1.31.0 where the same result $ busybox sh -c 'fn() { local v; echo "v: ${v-(unset)}"; }; v=global; fn'
v: (unset) |
Ah OK there was a bug in the environment, leading me to run the wrong ash: Passes now: http://travis-ci.oilshell.org/jobs/2020-04-18__19-07-12.wwz/_tmp/spec/ble-features.html Thanks! |
OK no problem! I fixed it: 5753cba |
Thank you! |
Test cases for #706