[test/spec] Failing spec tests for rvalue dynamic var name in arith #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah OK I just added the 4 failing ones to cover the lvalue. But this is for both lvalue and rvalue? Maybe prefix the test case names with ble.sh: so we remember where they came from, since this file is very long. It looks like it's matching the usage pattern of ble.sh which is good. |
akinomyoga
force-pushed
the
add-tests-arith-dynamic-varname
branch
from
04cc1ad to
204b3d2
Compare
|
204b3d2 Thank you! I updated the test names (and also rebased on the latest commit on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to demonstrate a use case of dynamical rvalue/lvalue variable names in arithmetic expressions.