-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sending acr_values #331
Comments
Due to the fact that no progress was seen as to assignment or otherwise, i have forked the repo and have been working on a own implementation.
|
@Glowsome sounds good PRs are always welcome. Things have gotten busy the past many months and I've been more recently trying to get the project in better shape for other developers to contribute and spin up a local development environment easier. I've also been working on PHP & WordPress version compatibility testing. |
For your info, i have the fork running on a testsite with :
Latest additions to code are as stated above the implemenatation of verification if (when defined) the acr_values returned in the ID_token are the same as the value defined in the options of the plugin. This is (next to the fact it is defined in the specs) to avoid url manipulation where one might be able to escape imposed authentication methods. |
@timnolte do beware that i bumped the version of the addon in the PR to above release to avoid it being overwritten locally. |
@Glowsome hmm, generally I don't want people bumping the version, though I need to make sure that I bump the version to a future alpha after a release to assist with development testing. Can you revert that version bump and I will do so and then you can rebase with the latest. I have some dependency and local development changes to merge in as well, including some fixes for translations. |
@timnolte i will revise the PR to not bump the version as requested. |
Done |
Is your feature request related to a problem? Please describe.
The current implementation does not support asking for a specific authentication-contract by means of sending the parameter 'acr_values' as described in https://openid.net/specs/openid-connect-core-1_0.html - section 5.5.1.1.
Describe the solution you'd like
It would be very wishfull to be able to (when needed) specify the authentication contract available on an IDP via the acr_values parameter.
Describe alternatives you've considered
There is no alternative , as IDP's can have multiple authentication contracts available.
When no acr_values -parameter is sent with the authentication request an IDP will execute the default authentication contract, so there is no option to explicitly select one.
Additional context
In my situation my IDP has multiple authentication contracts :
Via other OpenID implementations i can ( from the application side ) explicitly ask for my multifactor contract by sending the contract-name ( urn) in the acr_values - parameter.
If i omit this (optional) parameter as stated above the default contract will be executed.
The text was updated successfully, but these errors were encountered: