-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SBT 1.0.x #50
Comments
Hi @michaelahlers! I was going to publish the plugin for sbt 1.0, but right now I don't have time for it at all. It should be very straightforward. If you know how, please submit a PR. |
I'm happy to give it a shot! Just don't know when I'll find the time. Hopefully soon and I'll follow up! |
It seems some dependencies also require to be bumped to 1.0.1/2.12 and there is quite a circular depency there (sbt-s3-resolver depends on nice-sbt-settings which requires itself and sbt-s3-resolver). |
@hkupty no-no, don't worry, you don't need to update the plugin to build a project. It's like when you're working on a normal sbt project, you can use any version of scala for your code in the project, while the sbt plugins in the meta-project will be using scala version correspondent to the running sbt. So in short, what you need to to here to upgrade this plugin to sbt-1.0:
It should be very easy, but I would really appreciate a pull-request with these simple changes. Then I can cut a release this weekend. |
I'll try my hand at this. |
Hey guys! Thanks to @macalinao the plugin now is upgraded to sbt-1.x 👏 I just released v0.17.0 (see release notes), but there's an important change: plugin now is published to Bintray. addSbtPlugin("ohnosequences" % "sbt-s3-resolver" % "0.17.0") in your |
UpdateIn the end I realised that I was confused about JCenter: I thought that it's one of the default resolvers in sbt, but it's not. You can include it with resolvers += Resolver.jcenterRepo
addSbtPlugin("ohnosequences" % "sbt-s3-resolver" % "0.17.0") Sorry for the confusion. |
With the 1.0.x release of SBT, plugins are needed compiled against Scala 2.12. In other words, with
sbt.version = 1.0.1
(for example), this error occurs on dependency resolution:The text was updated successfully, but these errors were encountered: