Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade is broken on Centos 7 #311

Closed
flytbird opened this issue Feb 22, 2022 · 1 comment
Closed

Upgrade is broken on Centos 7 #311

flytbird opened this issue Feb 22, 2022 · 1 comment

Comments

@flytbird
Copy link

Hi,

Since commit 463b9c3 (tools/upgrade: Return to the original working directory after upgrading) upgrade process is broken.
The reason is on Centos 7 git version (1.8.3.1) doesn't have "-C" option.

Regards,
@akinomyoga
Copy link
Contributor

Thank you for the report! I have pushed a fix 9909fff to master. The option -C seems to have been only supported from 1.8.5 (git/git@44e1e4d). On the other hand, the options --git-dir and --work-tree seems to have ben supported since 1.5.3 (git/git@892c41b). I switched to use --git-dir and --work-tree.

@akinomyoga akinomyoga mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flytbird @akinomyoga