Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript MatchResult object incomplete #494

Open
tonydoesathing opened this issue Oct 10, 2024 · 1 comment
Open

Typescript MatchResult object incomplete #494

tonydoesathing opened this issue Oct 10, 2024 · 1 comment

Comments

@tonydoesathing
Copy link

Version: 17.1.0

Noticed the following when it comes to the types; current MatchResults interface only contains the following:

export interface MatchResult {
  succeeded(): boolean;
  failed(): boolean;
  message?: string;
  shortMessage?: string;
  getInterval(): Interval;
}

On inspection, looks like it's missing the following fields:

input:string;
matcher: Matcher;
startExpr:Seq;
getExpectedText(): string;
getRightmostFailurePosition(): number;
getRightmostFailures(): Failure[];
@pdubroy
Copy link
Contributor

pdubroy commented Nov 5, 2024

Thanks, yes! We should update the type definitions. Will try to push something out in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@pdubroy @tonydoesathing and others