Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update area of specialisation of doctor #7664

Merged
merged 11 commits into from
May 15, 2024

Conversation

rash-27
Copy link
Contributor

@rash-27 rash-27 commented Apr 19, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rash-27 rash-27 requested a review from a team as a code owner April 19, 2024 16:33
Copy link

vercel bot commented Apr 19, 2024

@rash-27 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit efd59d6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66445059468a0f000894a4af
😎 Deploy Preview https://deploy-preview-7664--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rash-27
Copy link
Contributor Author

rash-27 commented Apr 19, 2024

@nihal467 @aparnacoronasafe In this issue, we are synchronising the doctor types with available skills and using staff capacity instead of the doctor's list in the facility dashboard. I feel like we can completely go with the staff capacity in the facility dashboard and make corresponding changes to shift from displaying doctors to staff.The changes include

  • Changing the route names that we are using currently using to fetch staff details (/api/v1/facility/{facilityId}/hospital_doctor/ and /api/v1/facility/{facilityId}/hospital_doctor/{id}/) for more readability
  • And also making changes in the frontend like, the notifications currently are displaying "Doctor count added successfully" and we can change them to "Staff count added successfully" and etc.
  • And also in frontend code can we change the variable names accordingly for more readability of the code as currently we are displaying the Staff details in facility dashboard instead of doctors details ?
    What do you think?

@nihal467
Copy link
Member

@rash-27 any update on this PR

@nihal467
Copy link
Member

@rithviknishad can you update the following bugs

@nihal467
Copy link
Member

nihal467 commented May 15, 2024

image

  • change all doctor related text to staff related text in the facility create work flow

@nihal467
Copy link
Member

nihal467 commented May 15, 2024

image

  • modify the delete pop-up text and relate notification (create, update, and delete)

@nihal467
Copy link
Member

nihal467 commented May 15, 2024

image

  • update the existing data modify pop-up and update doctor capacity capacity

@nihal467
Copy link
Member

nihal467 commented May 15, 2024

image

  • change it to total staff count

src/Common/constants.tsx Outdated Show resolved Hide resolved
src/Common/constants.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit c8a1549 into ohcnetwork:develop May 15, 2024
30 of 32 checks passed
Copy link

@rithviknishad @rash-27 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Areas of Specializations needs to Be increased to a Doctor w.r.t. facility Details
4 participants