Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The install instructions for OSX is outdated for M1 Macs. #89

Open
peauc opened this issue Oct 17, 2022 · 0 comments
Open

The install instructions for OSX is outdated for M1 Macs. #89

peauc opened this issue Oct 17, 2022 · 0 comments

Comments

@peauc
Copy link

peauc commented Oct 17, 2022

The README.md states

Add this to your ~/.config/fish/config.fish:

if test (uname -s) = "Darwin"
  set -gx PATH /usr/local/opt/coreutils/libexec/gnubin $PATH
  set -gx PATH /usr/local/opt/gnu-sed/libexec/gnubin $PATH
end

However as per brew documentation:

[Brew installation folder...]:
/usr/local for macOS on Intel,
/opt/homebrew for macOS on Apple Silicon/ARM, and
/home/linuxbrew/.linuxbrew for Linux.

For my installation I had to change the path to ( and i added fish_add_path )

if test (uname -s) = 'Darwin' 
   and test (uname -p) = "arm"
  fish_add_path -p /opt/homebrew/opt/coreutils/libexec/gnubin
  fish_add_path -p /opt/homebrew/opt/gnu-sed/libexec/gnubin
end

I could draft a PR tackling this change. Thank you for your work on this amazing theme.

@peauc peauc changed the title The install instructions for OSX is outdated. The install instructions for OSX is outdated for M1 Macs. Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant