From 3b7c04d422dc4c6be0c4a89c5b94387be161f88c Mon Sep 17 00:00:00 2001
From: Oliver Gupte <olivergupte@gmail.com>
Date: Wed, 29 Jul 2020 01:26:36 -0700
Subject: [PATCH] Closes #72914 by hiding anomaly detection settings links when
 the ml plugin is disabled.

---
 .../apm/public/components/app/Home/index.tsx  | 11 ++++---
 .../anomaly_detection/add_environments.tsx    |  2 +-
 .../app/Settings/anomaly_detection/index.tsx  |  4 +--
 .../public/components/app/Settings/index.tsx  | 33 ++++++++++++-------
 4 files changed, 32 insertions(+), 18 deletions(-)

diff --git a/x-pack/plugins/apm/public/components/app/Home/index.tsx b/x-pack/plugins/apm/public/components/app/Home/index.tsx
index b09c03f853aa9..c6c0861c26a34 100644
--- a/x-pack/plugins/apm/public/components/app/Home/index.tsx
+++ b/x-pack/plugins/apm/public/components/app/Home/index.tsx
@@ -83,7 +83,8 @@ interface Props {
 }
 
 export function Home({ tab }: Props) {
-  const { config } = useApmPluginContext();
+  const { config, core } = useApmPluginContext();
+  const isMLEnabled = !!core.application.capabilities.ml;
   const homeTabs = getHomeTabs(config);
   const selectedTab = homeTabs.find(
     (homeTab) => homeTab.name === tab
@@ -105,9 +106,11 @@ export function Home({ tab }: Props) {
               </EuiButtonEmpty>
             </SettingsLink>
           </EuiFlexItem>
-          <EuiFlexItem grow={false}>
-            <AnomalyDetectionSetupLink />
-          </EuiFlexItem>
+          {isMLEnabled && (
+            <EuiFlexItem grow={false}>
+              <AnomalyDetectionSetupLink />
+            </EuiFlexItem>
+          )}
           <EuiFlexItem grow={false}>
             <SetupInstructionsLink />
           </EuiFlexItem>
diff --git a/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx b/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx
index cb2090d1cbe2b..3c323cf8fa161 100644
--- a/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx
+++ b/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx
@@ -64,7 +64,7 @@ export function AddEnvironments({
     return (
       <EuiPanel>
         <EuiEmptyPrompt
-          iconType="warning"
+          iconType="alert"
           body={<>{MLErrorMessages.MISSING_WRITE_PRIVILEGES}</>}
         />
       </EuiPanel>
diff --git a/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx b/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
index dab30761c6ebe..11d3b766d2293 100644
--- a/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
+++ b/x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
@@ -30,7 +30,7 @@ const DEFAULT_VALUE: AnomalyDetectionApiResponse = {
 
 export function AnomalyDetection() {
   const plugin = useApmPluginContext();
-  const canGetJobs = !!plugin.core.application.capabilities.ml.canGetJobs;
+  const canGetJobs = !!plugin.core.application.capabilities.ml?.canGetJobs;
   const license = useLicense();
   const hasValidLicense = license?.isActive && license?.hasAtLeast('platinum');
 
@@ -66,7 +66,7 @@ export function AnomalyDetection() {
     return (
       <EuiPanel>
         <EuiEmptyPrompt
-          iconType="warning"
+          iconType="alert"
           body={<>{MLErrorMessages.MISSING_READ_PRIVILEGES}</>}
         />
       </EuiPanel>
diff --git a/x-pack/plugins/apm/public/components/app/Settings/index.tsx b/x-pack/plugins/apm/public/components/app/Settings/index.tsx
index bd2ea706e492d..1471bc345d850 100644
--- a/x-pack/plugins/apm/public/components/app/Settings/index.tsx
+++ b/x-pack/plugins/apm/public/components/app/Settings/index.tsx
@@ -16,8 +16,11 @@ import {
 import { HomeLink } from '../../shared/Links/apm/HomeLink';
 import { useLocation } from '../../../hooks/useLocation';
 import { getAPMHref } from '../../shared/Links/apm/APMLink';
+import { useApmPluginContext } from '../../../hooks/useApmPluginContext';
 
 export function Settings(props: { children: ReactNode }) {
+  const plugin = useApmPluginContext();
+  const isMLEnabled = !!plugin.core.application.capabilities.ml;
   const { search, pathname } = useLocation();
   return (
     <>
@@ -48,17 +51,25 @@ export function Settings(props: { children: ReactNode }) {
                       '/settings/agent-configuration'
                     ),
                   },
-                  {
-                    name: i18n.translate(
-                      'xpack.apm.settings.anomalyDetection',
-                      {
-                        defaultMessage: 'Anomaly detection',
-                      }
-                    ),
-                    id: '4',
-                    href: getAPMHref('/settings/anomaly-detection', search),
-                    isSelected: pathname === '/settings/anomaly-detection',
-                  },
+                  ...(isMLEnabled
+                    ? [
+                        {
+                          name: i18n.translate(
+                            'xpack.apm.settings.anomalyDetection',
+                            {
+                              defaultMessage: 'Anomaly detection',
+                            }
+                          ),
+                          id: '4',
+                          href: getAPMHref(
+                            '/settings/anomaly-detection',
+                            search
+                          ),
+                          isSelected:
+                            pathname === '/settings/anomaly-detection',
+                        },
+                      ]
+                    : []),
                   {
                     name: i18n.translate('xpack.apm.settings.customizeApp', {
                       defaultMessage: 'Customize app',