Always use Ember object get.
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many places, we're currently accessing with this.varName, which prevents people using computed properties.
blimmer
force-pushed
the
chore/use-ember-obj-get-in-dummy-snippets
branch
from
4b5131d
to
7e448eb
Compare
|
Thanks 😸! |
|
@blimmer I went ahead and published a patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places, we're currently accessing with this.varName, which prevents people using computed properties.
Also, in my experience, this can be a confusing anti-pattern for those new to Ember. Many will copy from the demo app, so want to make sure people get used to this pattern.