Update all the things #564
Conversation
LICENSE.md
Outdated
| @@ -1,27 +1,9 @@ | |||
| Copyright 2016 Yahoo Inc. | |||
There was a problem hiding this comment.
Should probably bring back the original here
There was a problem hiding this comment.
Im not sure here! Since Yahoo as an entity no longer exists, im not sure that the license still stands? If that's not the case, I'll revert it back to the BSD-3 license.
There was a problem hiding this comment.
Ended up reverting the license back.
| @@ -1,29 +1,15 @@ | |||
| /** | |||
There was a problem hiding this comment.
I don't think so. I've looked at some older yahoo OSS and they dont have it. I think just the BSD-3 license was enough.
| @@ -33,7 +26,7 @@ export function unwrapProxy(o) { | |||
| } | |||
|
|
|||
| export function isProxy(o) { | |||
| return !!(o && (o instanceof Ember.ObjectProxy || o instanceof Ember.ArrayProxy)); | |||
| return !!(o && (o instanceof ObjectProxy || o instanceof ArrayProxy)); | |||
There was a problem hiding this comment.
Might also want to check for unknownProperty (I know this is unrelated)
Happy to chat through it, though I'm not sure off the cuff exactly what breaks for this ATM... |
My concern with the new CP For example when you get a validator like this: {
myProp: validator('presence', {
presence: true,
disabled: computed('model.foo', '[email protected]', function () {})
});
}We would extract the dependent keys from the disabled CP and add them to the This currently happens here. It looks like the only thing that is breaking is the test case (since its trying to do someEmberObject.someProp.isDescriptor which throws since in the future someProp would return the computed value). Do you think the that logic we have now for extracting the dependentKeys is still okay? |
Changes proposed:
Todo (in different PRs)
Fix ember beta env issue with the descriptor changes (@rwjblue would love some input on that)