Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking error in citySupportChange type-safety checks #3251

Conversation

jaj22
Copy link

@jaj22 jaj22 commented May 15, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

The safety checks added to citySupportChange for command line usage currently break when a position is used as input to citySupportChange. This PR fixes it.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Go into a town and steal a car.

@jaj22 jaj22 added Priority Should be fixed first Bug Something isn't working Review pending labels May 15, 2024
@jaj22 jaj22 requested a review from Tiny-DM May 15, 2024 03:28
Copy link

@Tiny-DM Tiny-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crying, but LGTM

@Bob-Murphy Bob-Murphy added this to the 3.6 milestone May 17, 2024
@Bob-Murphy Bob-Murphy merged commit a99fc2c into official-antistasi-community:unstable May 17, 2024
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Bug Something isn't working Priority Should be fixed first Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants