fix: fix verification email being sent twice #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaiss
commented
Jun 4, 2021
|
Kudos, SonarCloud Quality Gate passed! |
|
This behavior is due to (or thanks to?)
... which is actually pretty nice! |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have NO idea how it's possible, but somehow the verification email is sent twice during registration.
When I delete the line where we send the email ourself, the email is only sent twice.
So it fixes the bug. BUT...
As the line to send the email is deleted, why do we still send the email? I think it's because of Fortify somehow. I've read the entire Fortify codebase but I don't see anywhere how come it sends an email.
So. The bug is fixed but I don't know why the app keeps sending the email.