Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to change language #930

Merged
merged 34 commits into from
May 30, 2021
Merged

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented May 30, 2021

Moreover, this PR adds a new middleware, ShareInertiaData, which is an override of the middleware that ships with Jetstream, and which initially broadcasted the entire User object to Inertia, which sucked. So by overriding it, we are able to keep our data private.

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@djaiss djaiss marked this pull request as ready for review May 30, 2021 23:11
@djaiss djaiss requested a review from a team as a code owner May 30, 2021 23:11
@djaiss djaiss requested review from asbiin and removed request for a team May 30, 2021 23:11
@djaiss djaiss merged commit 1afdd3f into main May 30, 2021
@djaiss djaiss deleted the 2021-05-30-change-language branch May 30, 2021 23:12
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants