Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(technical): integrate laravel-cloudflare #622

Merged
merged 4 commits into from
May 24, 2021
Merged

feat(technical): integrate laravel-cloudflare #622

merged 4 commits into from
May 24, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Mar 14, 2021 •
edited
Loading

This adds a new variable APP_TRUSTED_CLOUDFLARE
It's false (deactivated) by default

@asbiin asbiin requested a review from a team as a code owner March 14, 2021 13:31
@asbiin asbiin requested review from djaiss and removed request for a team March 14, 2021 13:31
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

33.3% 33.3% Coverage
0.0% 0.0% Duplication

djaiss
djaiss approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just don't understand the benefits of using Cloudflare in our context.

@asbiin
Copy link
Contributor Author

asbiin commented Apr 20, 2021

@djaiss what should we do with that one?
Cloudflare is super practical to handle dns in one place, with https. But we can use alternative ...

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 6b7d581 into main May 24, 2021
@asbiin asbiin deleted the 20210314-laravel-cloudflare branch May 24, 2021 22:08
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.0-alpha.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss approved these changes

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asbiin @djaiss