Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set autocomplete=off in assign project lead input #571

Merged
merged 2 commits into from
Apr 3, 2021
Merged

fix: set autocomplete=off in assign project lead input #571

merged 2 commits into from
Apr 3, 2021

Conversation

haidang666
Copy link
Contributor

@haidang666 haidang666 commented Feb 21, 2021 •
edited
Loading

  • [x ] Unit tests
  • [x ] Tests with Cypress
  • Documentation
  • Dummy data

When searching for employee to assign, an autocomplete will show up and block the search result, thus users have to click in the outerspace to close it.

Screen Shot 2021-02-20 at 9 00 28 pm

@djaiss
Copy link
Member

djaiss commented Feb 23, 2021

To be honest I didn't expect anyone to contribute considering the state of the project. It’s not even launched yet and the repository is not really ready for external contributors.

That being said, thanks so much for taking the time to understand the product and try to make it better. The project is not yet ready for prime time, but every help helps!

So, thanks!

@haidang666
Copy link
Contributor Author

To be honest I didn't expect anyone to contribute considering the state of the project. It’s not even launched yet and the repository is not really ready for external contributors.

That being said, thanks so much for taking the time to understand the product and try to make it better. The project is not yet ready for prime time, but every help helps!

So, thanks!

Oh sorry for the inconvenience, I just thought it is good for me to follow from the beginning. Again, sorry for it but If you need a hand for doing little stuff, I'd like to help.

@djaiss
Copy link
Member

djaiss commented Apr 3, 2021

Oh sorry for the inconvenience, I just thought it is good for me to follow from the beginning. Again, sorry for it but If you need a hand for doing little stuff, I'd like to help.

No problem at all. In fact, I would like to thank you very, very much for taking the time to setup the project and start to play with it.

Did you enjoy your experience so far?

@djaiss djaiss merged commit f06d470 into officelifehq:main Apr 3, 2021
@haidang666
Copy link
Contributor Author

Oh sorry for the inconvenience, I just thought it is good for me to follow from the beginning. Again, sorry for it but If you need a hand for doing little stuff, I'd like to help.

No problem at all. In fact, I would like to thank you very, very much for taking the time to setup the project and start to play with it.

Did you enjoy your experience so far?

Sure. I've learned new stuff in both design structure and supporting tools which I definitely use in the future.

@haidang666 haidang666 deleted the add_lead_in_create_project branch April 4, 2021 04:25
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haidang666 @djaiss