Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manager approvals of timesheets #464

Merged
merged 7 commits into from
Jan 3, 2021

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Dec 29, 2020

This PR allows managers to approve or reject timesheets. This simply marks the timesheet as approved or rejected, and employees are not yet notified. We will cover this in another PR.

Blank state

image

Not blank state

image

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2021

Images automagically compressed by Calibre's image-actions

Compression reduced images by 30.6%, saving 3.99 KB.

Filename Before After Improvement Visual comparison
public/img/[email protected] 13.04 KB 9.05 KB -30.6% View diff

39 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@djaiss djaiss marked this pull request as ready for review January 3, 2021 15:50
@djaiss djaiss enabled auto-merge (squash) January 3, 2021 15:52
@djaiss
Copy link
Member Author

djaiss commented Jan 3, 2021

The Cypress tests were a pain to write 😢

@djaiss djaiss merged commit 70526e6 into main Jan 3, 2021
@djaiss djaiss deleted the 2020-12-29-approve-timesheet-by-manager branch January 3, 2021 15:57
@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

75.6% 75.6% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant