Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add messages in project #355

Merged
merged 14 commits into from
Nov 1, 2020
Merged

feat: add messages in project #355

merged 14 commits into from
Nov 1, 2020

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Oct 29, 2020 •
edited
Loading

This PR adds the ability to manage messages in the context of a project.

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions ✨

Compression reduced images by 26.2%, saving 2.10 KB.

Filename Before After Improvement Visual comparison
public/img/[email protected] 8.01 KB 5.91 KB -26.2% View diff

34 images did not require optimisation.

@djaiss djaiss marked this pull request as draft November 1, 2020 01:19
@djaiss djaiss added the cypress label Nov 1, 2020
@djaiss djaiss marked this pull request as ready for review November 1, 2020 16:47
@djaiss djaiss requested a review from asbiin November 1, 2020 16:48
asbiin
asbiin requested changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
See some comments

app/Helpers/LogHelper.php Outdated Show resolved Hide resolved
app/Models/Company/Project.php Outdated Show resolved Hide resolved
database/factories/CompanyFactory.php Show resolved Hide resolved
resources/js/Pages/Project/Members/Index.vue Show resolved Hide resolved
resources/js/Pages/Project/Messages/Index.vue Outdated Show resolved Hide resolved
routes/web.php Outdated Show resolved Hide resolved
resources/js/Pages/Project/Message.vue Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

81.3% 81.3% Coverage
2.5% 2.5% Duplication

@djaiss
Copy link
Member Author

djaiss commented Nov 1, 2020

Alright, fixed everything.

@djaiss djaiss merged commit 2f0c1f6 into main Nov 1, 2020
@djaiss djaiss deleted the 2020-10-26-messages branch November 1, 2020 22:48
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

🎉 This PR is included in version 0.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asbiin asbiin asbiin requested changes

Assignees
No one assigned
Labels
cypress released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djaiss @asbiin