Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix ball-pulse css removal #310

Merged
merged 1 commit into from
Oct 20, 2020
Merged

fix: fix ball-pulse css removal #310

merged 1 commit into from
Oct 20, 2020

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Oct 19, 2020 •
edited
Loading

  • Add ball-pulse css class name to purgecss' whitelist
  • Also add 'false' parameter to sourcemap to not create them on production

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin changed the title fix: fix ball-pulse css removed fix: fix ball-pulse css removal Oct 19, 2020
@asbiin asbiin requested a review from djaiss October 19, 2020 22:35
djaiss
djaiss reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that an issue now?

@asbiin
Copy link
Contributor Author

asbiin commented Oct 20, 2020

purgeCss allow to remove unused css class. It detect the class that are required automatically, but for ball-pulse it seems it's a soft link that is not detected by purgeCss.
With this change you can add a regex to exclude some css class being removed by prugeCss

@asbiin asbiin merged commit b19eecd into main Oct 20, 2020
@asbiin asbiin deleted the 20201020-fix-ball-pulse branch October 20, 2020 06:19
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

🎉 This PR is included in version 0.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss left review comments

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asbiin @djaiss