Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rudybot quotes ACTION methods sometimes #14

Open
ijp opened this issue Nov 20, 2012 · 3 comments
Open

rudybot quotes ACTION methods sometimes #14

ijp opened this issue Nov 20, 2012 · 3 comments

Comments

@ijp
Copy link
Contributor

ijp commented Nov 20, 2012

<ijp> rudybot: remember the dark days of internet usage: before firefox
      panorama?
<rudybot> ijp: ACTION waits for someone to write a "firefox panorama" for
          emacs

I see two strategies for fixing this:

  1. no quoting ACTIONs
  2. having rudybot actually reply with an ACTION
@offby1
Copy link
Owner

offby1 commented Apr 6, 2013

My hunch is that the code itself is fine, although it used to be buggy in that it would fail to trim off the word ACTION before inserting into the database. If I'm right, the only thing that needs to be done is for me to delete the bugaceous database entries.

@ijp
Copy link
Contributor Author

ijp commented Sep 28, 2013

after testing, and looking at the code, I think you are right. closing.

@ijp ijp closed this as completed Sep 28, 2013
@offby1
Copy link
Owner

offby1 commented Sep 28, 2013

The db is indeed full of bogus entries that need to be cleaned out:

    select * from log where text like '_ACTION %';

shows many many many of 'em. This probably doesn't warrant reopening this bug, but it feels wrong.

@offby1 offby1 reopened this Sep 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants