Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard & API writing order #42

Open
oeed opened this issue Feb 2, 2016 · 8 comments
Open

Standard & API writing order #42

oeed opened this issue Feb 2, 2016 · 8 comments

Comments

@oeed
Copy link
Owner

oeed commented Feb 2, 2016

Although I had originally stated that the API should be written before the pull request is made I'm not so sure it's the right process. Instead I think that the API should be written after the standard has approval. The PR can then have a awaiting api label assigned to it along with accepted.

@viluon
Copy link
Collaborator

viluon commented Feb 2, 2016

In that case, I'd suggest that the author should submit 2 PRs, one with the proposal (proposal) (which won't be merged, but you need to store the associated Markdown docs somewhere) and when that's accepted,(s)he submits another one (standard) with the actual standard and utilities.

@viluon
Copy link
Collaborator

viluon commented Feb 5, 2016

What do you think of that @oeed ?

@oeed
Copy link
Owner Author

oeed commented Feb 5, 2016

Hmm, actually that might work. Although, it separates things a bit too much I feel.

@viluon
Copy link
Collaborator

viluon commented Feb 5, 2016

Agreed, although cross-referencing the PRs might help with that..

@lyqyd
Copy link
Collaborator

lyqyd commented Feb 9, 2016

What's the need for a second PR? May as well make any necessary changes on the initial one, and simply not pull until it's ready. I'm having trouble seeing what the added benefit is to using a separate PR for the final standard text.

@oeed
Copy link
Owner Author

oeed commented Feb 10, 2016

Yeah I'd agree with @lyqyd, @viluon.

@viluon
Copy link
Collaborator

viluon commented Feb 10, 2016

Well, I know that 2 PRs is silly @oeed, but as it sort of "works" now, people open PRs when they've got nothing completed really... I'd like to fix that, just don't know how.

@oeed
Copy link
Owner Author

oeed commented Feb 10, 2016

I don't see a huge issue with the current PRs. Sure, it'd be nice if we could merge them faster, but placing too many barriers will just deter people from contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants