[BUG] Default value for Parameter not used in execution

[jugdemon]

Environment

• ODTP/ODTP Component version: odtp-eqasim
• Operating System: Ubuntu 24.04.1 LTS
• Browser: (if applicable)

Bug description

The default value for a parameter is not used.

Summary:

We setup the eqasim pipeline. We don't provide parameters because the default is set to the scenario we want to test. The execution fails for a parameter. First the scenario was CH instead of Corsica and second hts was not set after we forced scenario to Corsica. Both scenario and hts have defaults that should load Corsica with the entd.

Steps to reproduce the bug:

1. Create eqasim pipeline
2. Don't add parameters
3. Run

Expected behavior

The default parameters are loaded and the full pipeline is executed.

Actual behavior

The execution fails because parameters are not set.

Severity and impact

• Severity: Critical
• Impact: A simple demo cannot be shown because all parameters need to be meticously set defeating the purpose of defaults.

Supporting information

• Upon request.

[sabinem]

@jugdemon Currently we are not reading the odtp.yml file in odtp. But it is possible to get the default parameters from there and to store them on the component version. So what you want here is clear and makes sense to me.

[sabinem]

@jugdemon One problem I see here is that the odtp.yml files have not been checked in previous versions of the components to make sure that they contain valid yaml.

• So for the future we can implement this check for the components
• Some existing versions of components should then be deprecated as they don't have valid yaml files.
  Would that be okay for you?

[jugdemon]

I believe that is absolutely necessary. I think loading a component without a valid yml should cause s warning to appear in odtp indicating limited functionality. We can also indicates that in the future these component with no longer work.

Maybe we can have a developer mode in odtp that can be enabled to work with incomplete ymls then? It would be nice to complete them in the UI but I guess that would require the right to write to the components repo - so that is probably out of scope for now. But odtp setting with a dev mode to test a component with an incomplete yml could ne interesting.

I guess those odtp setting could also be where you can set the link to the zoo you want to use. Should we make a new issue about settings as to keep this clean?

[sabinem]

@jugdemon

Maybe we can have a developer mode in odtp that can be enabled to work with incomplete ymls then?

I think the development mode is the cli not the gui. In the GUI I would like to keep it simple.

I would then skip the step in the execution run, where parameters can be uploaded from file and just add the parameter overwrite step: so for steps where default parameters are missing: all parameters would have to be added manually. But anyway these component versions are marked in the UI and should not be used any more.

When you add a new component version a parsable odtp.yml will be required and you will not be able to add it unless you have corrected the odtp.yml.

Yes for a link to the zoo, that would be another ticket.