Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firehose_sink_http_response_code_total metric sends url tag. The tag values can be unbounded. #146

Closed
lavkesh opened this issue Dec 8, 2021 · 1 comment
Assignees

Comments

@lavkesh
Copy link
Member

lavkesh commented Dec 8, 2021

🐛 Bug Report

private void captureHttpStatusCount(HttpEntityEnclosingRequestBase httpRequestMethod, HttpResponse response) {
        String urlTag = "url=" + httpRequestMethod.getURI().getPath();
        String statusCode = statusCode(response);
        String httpCodeTag = statusCode.equals("null") ? "status_code=" : "status_code=" + statusCode;
        getInstrumentation().captureCount(SINK_HTTP_RESPONSE_CODE_TOTAL, 1, httpCodeTag, urlTag);
    }

URL can be unbounded which can results into large number of series.

Expected Behavior

URL tag should not be sent.

Steps to Reproduce

Steps to reproduce the behavior.

  1. Run firehose
  2. Have cortex series limit.
  3. cortex will throw 400 when trying to push metrics after the series limit is reached.

Environment

Kubernetes

@lavkesh lavkesh self-assigned this Dec 8, 2021
@lavkesh lavkesh closed this as completed Dec 8, 2021
@lavkesh
Copy link
Member Author

lavkesh commented Dec 8, 2021

8fe1934
fixed .

@lavkesh lavkesh reopened this Dec 8, 2021
@lavkesh lavkesh closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant