Dataset option view crashes when the domain is not correct

[jok-adhoc]

Version (please indicate which version you are using):

• 17.0
• 18.0 potentially

Describe the bug
This bug occurs, at least in 17, when the domain of a dataset on odoo spreadsheet is not correct, it arises an error and the domain could not be change when clicking on the dataset options. I couldn't replicate it on 18 yet because there is a check step, but I think it could happen if the sheet comes from a migration process. This behaviour also prohibits users on 18 to move documents from a database to another if the document has a little domain error that they can change after uploading.

To Reproduce
This is a way to reproduce something that happens on migrations or moving osheets from a database to another

1. Go to any spreadsheet
2. Via JSON, modify the domain of a dataset that does not work (could be because the field is misspelled or does not exist)
3. Upload and update the file
4. Go to data menu and click the modified pivot
5. Crashes

Expected behavior
It is expected to be able to inspect the dataset and change the domain. It may contain a legend informing it is not correct

Attachments
A modification of sale.osheet default template is attached. Pivot 3's domain has been changed
Sales.osheet (5).json

[VincentSchippefilt]

Hello,
Thank you for your feedback.

Starting in 18.0, we put in place the spreadsheet must survive policy :)
Normally, you should not be able to make it crash, even with incorrect domains, or models, or anything like that.
Could you confirm that you are able to open your spreadsheet in 18.0 with incorrect domains ?

Thanks again,
Vincent

[jok-adhoc]

Hi @VincentSchippefilt ! Sorry for the delay

I have tested this case using a 17's database with a domain and dataset model (separately) that I knew they do not exist in 18 anymore. As expected, the user is allowed to open the spreadsheet and fix the domain or remove the dataset.

So this case only replicates migrating from 16 to 17.

Thank you :)