From f37b9981f528a201a6e2ca0af813a3f161539622 Mon Sep 17 00:00:00 2001
From: dhrp-odoo <dhrp@odoo.com>
Date: Tue, 12 Nov 2024 09:31:07 +0000
Subject: [PATCH] [FIX] data_bar_rule_editor: disable "No Color" button
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This PR introduces two changes:

1. Fixes a traceback error in the Conditional Formatting Databar
editor by hiding the "Reset" button when not applicable.

2. Prevents errors by validating color input earlier to avoid empty
string parsing issues.

closes odoo/o-spreadsheet#5349

Task: 4102704
X-original-commit: 23a005a53b16513ac9f934f34c55cc2502223fac
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Dhrutik Patel (dhrp) <dhrp@odoo.com>
---
 .../side_panel/conditional_formatting/cf_editor/cf_editor.ts  | 4 ++++
 .../conditional_formatting/cf_editor/data_bar_rule_editor.xml | 1 +
 2 files changed, 5 insertions(+)

diff --git a/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts b/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts
index 5cd376bd26..44ffa2bf9f 100644
--- a/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts
+++ b/src/components/side_panel/conditional_formatting/cf_editor/cf_editor.ts
@@ -629,6 +629,10 @@ export class ConditionalFormattingEditor extends Component<Props, SpreadsheetChi
   }
 
   updateDataBarColor(color: Color) {
+    if (!isColorValid(color)) {
+      return;
+    }
+
     this.state.rules.dataBar.color = Number.parseInt(color.slice(1), 16);
     this.updateConditionalFormat({ rule: this.state.rules.dataBar });
   }
diff --git a/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml b/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml
index b96da042bf..55d0f6cfe8 100644
--- a/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml
+++ b/src/components/side_panel/conditional_formatting/cf_editor/data_bar_rule_editor.xml
@@ -5,6 +5,7 @@
       <RoundColorPicker
         currentColor="colorNumberString(rule.color)"
         onColorPicked.bind="updateDataBarColor"
+        disableNoColor="true"
       />
       <div class="o-section-subtitle">Range of values</div>
       <SelectionInput