[FIX] ranges: getRangeFromSheetXC with invalid sheetId

When `getRangeFromSheetXC` is called, it either crashes or returns an
corrupted range. The getter should handle this case, and return an
invalid range.

closes #4779

Task: 3578461
X-original-commit: d6bc2b7
Signed-off-by: Adrien Minne (adrm) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>

src/plugins/core/range.ts

@@ -325,7 +325,7 @@ export class RangeAdapter implements CommandHandler<CoreCommand> {
    * @param sheetXC the string description of a range, in the form SheetName!XC:XC
    */
   getRangeFromSheetXC(defaultSheetId: UID, sheetXC: string): RangeImpl {
-    if (!rangeReference.test(sheetXC)) {
+    if (!rangeReference.test(sheetXC) || !this.getters.tryGetSheet(defaultSheetId)) {
       return new RangeImpl(
         {
           sheetId: "",

tests/range_plugin.test.ts

@@ -574,6 +574,28 @@ describe("range plugin", () => {
     deleteSheet(m, "s1");
     expect(m.getters.getRangeString(range)).toBe(CellErrorType.InvalidReference);
   });
+
+  test("getRangeFromSheetXC on invalid sheet", () => {
+    let getRange = () => m.getters.getRangeFromSheetXC("NotASheet", "A1");
+    expect(getRange).not.toThrow();
+    expect(getRange().invalidXc).toBe("A1");
+
+    getRange = () => m.getters.getRangeFromSheetXC("NotASheet", "A:A");
+    expect(getRange).not.toThrow();
+    expect(getRange().invalidXc).toBe("A:A");
+
+    getRange = () => m.getters.getRangeFromSheetXC("NotASheet", "Sheet1!A1");
+    expect(getRange).not.toThrow();
+    expect(getRange().invalidXc).toBe("Sheet1!A1");
+
+    getRange = () => m.getters.getRangeFromSheetXC("", "Sheet1!A:A");
+    expect(getRange).not.toThrow();
+    expect(getRange().invalidXc).toBe("Sheet1!A:A");
+
+    getRange = () => m.getters.getRangeFromSheetXC("", "A1:A2");
+    expect(getRange).not.toThrow();
+    expect(getRange().invalidXc).toBe("A1:A2");
+  });
 });
 
 describe("Helpers", () => {