[FIX] Find&Replace: always search cell content if searchFormula

The current implementation of a search with the option `serachFormula`
will only look into the cell content if the cell is a valid formula cell
and not a cell which results in an error following its evaluation.

e.g.  A1: '=SUM("a")' is invalid thus the related cell is not a formula
cell but an error cell and will never be matched when looking for the
term "sum".

closes #4990

Task: 4175968
X-original-commit: 4b485dd
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>

src/plugins/ui/find_and_replace.ts

@@ -170,11 +170,7 @@ export class FindAndReplacePlugin extends UIPlugin {
           cell &&
           this.currentSearchRegex &&
           this.currentSearchRegex.test(
-            this.searchOptions.searchFormulas
-              ? cell.isFormula()
-                ? cell.content
-                : String(cell.evaluated.value)
-              : String(cell.evaluated.value)
+            this.searchOptions.searchFormulas ? cell.content : String(cell.evaluated.value)
           )
         ) {
           const position = this.getters.getCellPosition(cell.id);

tests/plugins/find_and_replace.test.ts

@@ -16,7 +16,7 @@ import {
   unhideRows,
   updateFilter,
 } from "../test_helpers/commands_helpers";
-import { getCellContent, getCellText } from "../test_helpers/getters_helpers";
+import { getCellContent, getCellError, getCellText } from "../test_helpers/getters_helpers";
 
 let model: Model;
 let searchOptions: SearchOptions;
@@ -499,6 +499,20 @@ describe("search options", () => {
     expect(matchIndex).toBe(null);
   });
 
+  test("Search in formula searches cell content of a cell in error", () => {
+    const model = new Model();
+    setCellContent(model, "A1", "=notASumFunction(2)");
+    setCellContent(model, "A2", '=SUM("a")');
+    expect(getCellError(model, "A1")).toBeDefined();
+    expect(getCellError(model, "A2")).toBeDefined();
+    searchOptions.searchFormulas = true;
+    model.dispatch("UPDATE_SEARCH", { toSearch: "sum", searchOptions });
+    const matches = model.getters.getSearchMatches();
+    expect(matches).toHaveLength(2);
+    expect(matches[0]).toStrictEqual({ col: 0, row: 0, selected: true });
+    expect(matches[1]).toStrictEqual({ col: 0, row: 1, selected: false });
+  });
+
   test("Combine matching case / matching entire cell / search in formulas", () => {
     model.dispatch("UPDATE_SEARCH", { toSearch: "hell", searchOptions });
     let matches = model.getters.getSearchMatches();