[IMP] components: clickable pointer on checkbox label

This changes the mouse pointer when hovering a checkbox label. It indicates that it's clickable. Task: 4358098 Part-of: #5287 Signed-off-by: Rémi Rahir (rar) <[email protected]>
odoo · Dec 17, 2024 · 6aeccfb · 6aeccfb
1 parent 1e87515
commit 6aeccfb
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 0 deletions.
diff --git a/src/components/side_panel/components/checkbox/checkbox.ts b/src/components/side_panel/components/checkbox/checkbox.ts
@@ -34,6 +34,7 @@ css/* scss */ `
       box-sizing: border-box;
       outline: none;
       border: 1px solid ${GRAY_300};
+      cursor: pointer;
 
       &:hover {
         border-color: ${ACTION_COLOR};

diff --git a/src/components/side_panel/components/checkbox/checkbox.xml b/src/components/side_panel/components/checkbox/checkbox.xml
@@ -2,6 +2,7 @@
   <t t-name="o-spreadsheet.Checkbox">
     <label
       class="o-checkbox d-flex align-items-center"
+      role="button"
       t-att-title="props.title"
       t-att-class="{'text-muted': props.disabled }"
       t-attf-class="{{props.className}}">

diff --git a/tests/pivots/spreadsheet_pivot/__snapshots__/spreadsheet_pivot_side_panel.test.ts.snap b/tests/pivots/spreadsheet_pivot/__snapshots__/spreadsheet_pivot_side_panel.test.ts.snap
@@ -195,6 +195,7 @@ exports[`Spreadsheet pivot side panel It should correctly be displayed 1`] = `
           
           <label
             class="o-checkbox d-flex align-items-center"
+            role="button"
             title="Changing the pivot definition requires to reload the data. It may take some time."
           >
             <input
@@ -395,6 +396,7 @@ exports[`Spreadsheet pivot side panel It should display only the selection input
           
           <label
             class="o-checkbox d-flex align-items-center"
+            role="button"
             title="Changing the pivot definition requires to reload the data. It may take some time."
           >
             <input

diff --git a/tests/side_panels/building_blocks/__snapshots__/label_range.test.ts.snap b/tests/side_panels/building_blocks/__snapshots__/label_range.test.ts.snap
@@ -44,6 +44,7 @@ exports[`Label range Can add options to the label range component 1`] = `
     </div>
     <label
       class="o-checkbox d-flex align-items-center mt-2"
+      role="button"
     >
       <input
         class="me-2"

diff --git a/tests/side_panels/components/__snapshots__/checkbox.test.ts.snap b/tests/side_panels/components/__snapshots__/checkbox.test.ts.snap
@@ -4,6 +4,7 @@ exports[`Checkbox Can render a checkbox 1`] = `
 <div>
   <label
     class="o-checkbox d-flex align-items-center"
+    role="button"
   >
     <input
       class="me-2"
-Original file line number
+Diff line change
@@ Expand Up @@
         </div>
         <label
           class="o-checkbox d-flex align-items-center mt-2"
+          role="button"
         >
           <input
             class="me-2"
@@ Expand Down @@