[REM] menu: remove icons on menu items

This commit temporarilly disable icons on the left of menu items.
The reason is we don't have icons for *all* items. So some have an icon,
oters don't. This is weird.
When we will introduce icons for every menu items, we can revert this
commit.

closes #2046

Signed-off-by: Lucas Lefèvre (lul) <[email protected]>

src/components/menu/menu.ts

@@ -168,14 +168,10 @@ export class Menu extends Component<Props, SpreadsheetChildEnv> {
   }
 
   get childrenHaveIcon(): boolean {
-    return this.props.menuItems.some((menuItem) => !!menuItem.icon || !!menuItem.isActive);
+    return this.props.menuItems.some((menuItem) => !menuItem.icon && !!menuItem.isActive);
   }
 
   getIconName(menu: Action) {
-    if (menu.icon) {
-      return menu.icon;
-    }
-
     if (menu.isActive?.(this.env)) {
       return "o-spreadsheet-Icon.CHECK";
     }

tests/components/context_menu.test.ts

@@ -548,7 +548,7 @@ describe("Context Menu internal tests", () => {
     expect(fixture.querySelector(".o-menu div[data-name='subMenu']")).toBeTruthy();
   });
 
-  test("Menu with icon is correctly displayed", async () => {
+  test("Menu with icon is not displayed", async () => {
     const menuItems: Action[] = createActions([
       {
         id: "root1",
@@ -574,9 +574,9 @@ describe("Context Menu internal tests", () => {
       },
     ]);
     await renderContextMenu(300, 990, { menuItems });
-    expect(fixture.querySelector("div[data-name='root1'] svg")).not.toBeNull();
+    expect(fixture.querySelector("div[data-name='root1'] svg")).not.toBeNull(); // right caret
     await simulateClick("div[data-name='root1']");
-    expect(fixture.querySelector("div[data-name='root2'] svg")).not.toBeNull();
+    expect(fixture.querySelector("div[data-name='root2'] svg")).toBeNull();
     expect(fixture.querySelector("div[data-name='root3'] svg")).toBeNull();
   });