[FIX] pivot: divergent collaborative duplicated pivot name

Currently, if two users are connected to the same spreadsheet, both have
different languages and one of them duplicates a pivot: the spreadsheet
states have diverged because `_t(...)` gives two different results on both
sides.

Note that the command should ideally be upgraded with a script, but it's
not possible to get the original pivot name on the upgrade platform.

closes #5074

Task: 4199949
X-original-commit: e98ad44
Signed-off-by: Rémi Rahir (rar) <[email protected]>

src/plugins/core/pivot.ts

@@ -115,7 +115,7 @@ export class PivotCorePlugin extends CorePlugin<CoreState> implements CoreState
       case "DUPLICATE_PIVOT": {
         const { pivotId, newPivotId } = cmd;
         const pivot = deepCopy(this.getPivotCore(pivotId).definition);
-        pivot.name = _t("%s (copy)", pivot.name);
+        pivot.name = cmd.duplicatedPivotName ?? pivot.name + " (copy)";
         this.addPivot(newPivotId, pivot);
         break;
       }

src/plugins/ui_feature/insert_pivot.ts

@@ -80,6 +80,7 @@ export class InsertPivotPlugin extends UIPlugin {
     this.dispatch("DUPLICATE_PIVOT", {
       pivotId,
       newPivotId,
+      duplicatedPivotName: _t("%s (copy)", this.getters.getPivotCoreDefinition(pivotId).name),
     });
     const activeSheetId = this.getters.getActiveSheetId();
     const position = this.getters.getSheetIds().indexOf(activeSheetId) + 1;

src/types/commands.ts

@@ -653,6 +653,8 @@ export interface DuplicatePivotCommand {
   type: "DUPLICATE_PIVOT";
   pivotId: UID;
   newPivotId: string;
+  // an early version of the command did not include the duplicatedPivotName
+  duplicatedPivotName?: string;
 }
 
 // ------------------------------------------------

tests/test_helpers/constants.ts

@@ -447,6 +447,7 @@ export const TEST_COMMANDS: CommandMapping = {
     type: "DUPLICATE_PIVOT",
     pivotId: "1",
     newPivotId: "2",
+    duplicatedPivotName: "newName",
   },
   RENAME_PIVOT: {
     type: "RENAME_PIVOT",