Skip to content

Commit

Permalink
[FIX] pivots: don't translate pivot titles
Browse files Browse the repository at this point in the history
In standards dashboards, pivot titles are currently extracted from the json
files to be translated. But those titles are not visible in dashboard mode
(only in edit mode, in the side panels and menus). The cost of translating
those titles is not worth it.

closes #5061

Task: 4239967
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
  • Loading branch information
LucasLefevre committed Oct 21, 2024
1 parent b50c0f2 commit 2e95535
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/plugins/core/pivot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { compile } from "../../formulas";
import { deepCopy, deepEquals } from "../../helpers";
import { createPivotFormula, getMaxObjectId } from "../../helpers/pivot/pivot_helpers";
import { SpreadsheetPivotTable } from "../../helpers/pivot/table_spreadsheet_pivot";
import { _t } from "../../translation";
import {
ApplyRangeChange,
CellPosition,
Expand Down Expand Up @@ -162,7 +161,7 @@ export class PivotCorePlugin extends CorePlugin<CoreState> implements CoreState
}

getPivotName(pivotId: UID) {
return _t(this.getPivotCore(pivotId).definition.name);
return this.getPivotCore(pivotId).definition.name;
}

/**
Expand Down

0 comments on commit 2e95535

Please sign in to comment.