[FIX] autocomplete: Stop the range selection after selecting a pivot …

…proposal

The proposal selection of pivot autocomplete would put the composer in
an invalid state where we inserted some text while in range selection
mode without modifying the said state.

How to reproduce:
- Go to a runbot and insert a pivot in a spreadsheet
- type =pivot(
- Your have the dropddown taht suggests the id 1
- type enter to select it
--> your composer has =pivot(1 as content
- use the arrowkeys to the up/down
--> It pipes a cell reference next to the pivotID

closes #5035

Task: 4176481
X-original-commit: d89d673
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>

src/helpers/pivot/pivot_composer_helpers.ts

@@ -52,6 +52,7 @@ export function insertTokenAfterArgSeparator(
     // replace the whole token
     start = tokenAtCursor.start;
   }
+  this.composer.stopComposerRangeSelection();
   this.composer.changeComposerCursorSelection(start, end);
   this.composer.replaceComposerCursorSelection(value);
 }
@@ -74,6 +75,7 @@ export function insertTokenAfterLeftParenthesis(
     // replace the whole token
     start = tokenAtCursor.start;
   }
+  this.composer.stopComposerRangeSelection();
   this.composer.changeComposerCursorSelection(start, end);
   this.composer.replaceComposerCursorSelection(value);
 }

tests/composer/auto_complete/pivot_auto_complete_store.test.ts

@@ -24,6 +24,8 @@ describe("spreadsheet pivot auto complete", () => {
     );
     for (const func of ["PIVOT", "PIVOT.HEADER", "PIVOT.VALUE"]) {
       composer.startEdition(`=${func}(`);
+      expect(composer.isSelectingRange).toBeTruthy();
+
       const autoComplete = composer.autocompleteProvider;
       expect(autoComplete?.proposals).toEqual([
         {
@@ -41,6 +43,8 @@ describe("spreadsheet pivot auto complete", () => {
       ]);
       autoComplete?.selectProposal(autoComplete?.proposals[0].text);
       expect(composer.currentContent).toBe(`=${func}(1`);
+      // range selection stops
+      expect(composer.isSelectingRange).toBeFalsy();
       expect(composer.autocompleteProvider).toBeUndefined();
       composer.cancelEdition();
     }