[FIX] composer: don't auto-complete when hidden

Steps to reproduce: - type in a formula =SU - close the aut-completes with the cross at the top right corner - hit Enter => the formula is completed to =SUM( closes #4972 Task: 4176433 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
odoo · Sep 24, 2024 · 06ad5fe · 06ad5fe
1 parent ca638d9
commit 06ad5fe
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/components/composer/composer/composer.ts b/src/components/composer/composer/composer.ts
@@ -789,7 +789,7 @@ export class Composer extends Component<CellComposerProps, SpreadsheetChildEnv>
   }
 
   private autoComplete(value: string) {
-    if (!value) {
+    if (!value || this.assistant.forcedClosed) {
       return;
     }
     this.autoCompleteState.provider?.selectProposal(value);

diff --git a/tests/composer/autocomplete_dropdown_component.test.ts b/tests/composer/autocomplete_dropdown_component.test.ts
@@ -336,6 +336,24 @@ describe("Functions autocomplete", () => {
       expect(fixture.querySelector(".o-formula-assistant-container")).toBeTruthy();
       expect(fixture.querySelector("#formula-assistant-details")?.className).not.toContain("show");
     });
+
+    test("cannot auto-complete when it is closed", async () => {
+      await typeInComposer("=SU");
+      expect(document.activeElement).toBe(composerEl);
+      expect(fixture.querySelectorAll(".o-autocomplete-value")).toHaveLength(1);
+
+      // hide the auto-complete
+      await click(fixture, ".fa-times-circle");
+      expect(fixture.querySelectorAll(".o-autocomplete-value")).toHaveLength(0);
+      await keyDown({ key: "Enter" });
+      expect(composerStore.currentContent).toBe("=SU");
+
+      // show it again
+      await click(fixture, ".fa-question-circle");
+      expect(fixture.querySelectorAll(".o-autocomplete-value")).toHaveLength(1);
+      await keyDown({ key: "Enter" });
+      expect(composerStore.currentContent).toBe("=SUM(");
+    });
   });
 
   describe("autocomplete functions SUM IF", () => {