-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Head sampling crd #1445
Head sampling crd #1445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
added few nit suggestions about updating someplace to the new names, and consider removing the contains
operand for now, as it might get us into problems with eBPF implementation which we can postpone
Great job @tamirdavid1
Another thing to consider: spec:
runtimeDetailsInvalidated: false
configs:
- name: "net/http"
traceConfig:
enbaled: true
headSampling:
fallbackFraction: 0.4
rules:
- fraction: 1
operands:
- key: "http.method"
operation: "equal"
value: "POST"
dynamicAttributes:
- spanKind: "server"
optionValueBoolean: true
optionKey: "http.request.body"
global:
headSampling:
fallbackFraction: 0.9 It is a big change and I am not sure how much value it adds, but maybe now is a good time to do it if you find it valuable. (cc @blumamir @RonFed ) |
8061ae4
to
fa401d9
Compare
33a2191
to
d9c41ad
Compare
fc37bd3
to
a73cd8a
Compare
4cd5e3d
to
de331b1
Compare
I've added @RonFed CRD additions for Head-sampling + change in the relevant places in the code.