From e48b1ca3967b6a80fa879351d2a560303320c109 Mon Sep 17 00:00:00 2001
From: Ben Elferink <ben.elferink@icloud.com>
Date: Wed, 20 Nov 2024 17:20:41 +0200
Subject: [PATCH] [GEN-1753]: proper English for "running instance(s)" (#1800)

Co-authored-by: Alon Braymok <138359965+alonkeyval@users.noreply.github.com>
Co-authored-by: Tamir David <tamir@odigos.io>
Co-authored-by: Tamir David <tamirdavid@Tamirs-MacBook-Pro.local>
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Co-authored-by: Ron Federman <73110295+RonFed@users.noreply.github.com>
Co-authored-by: yodigos <yoav@odigos.io>
Co-authored-by: Mike Dame <mike@odigos.io>
Co-authored-by: alonbraymok <alonbraymok007@gmail.com>
Co-authored-by: Daria Dovzhikova <daria@odigos.io>
Co-authored-by: David <65228999+david336362@users.noreply.github.com>
Co-authored-by: David <david@odigos.io>
Co-authored-by: Eden Federman <eden@keyval.dev>
---
 .../choose-sources-body-fast/sources-list/index.tsx           | 4 ++--
 .../choose-sources-body-simple/sources-list/index.tsx         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx b/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx
index 32a00866b..a28c2427f 100644
--- a/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx
+++ b/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx
@@ -125,7 +125,7 @@ export const SourcesList: React.FC<Props> = ({
         const selected = selectedSources[namespace] || [];
         const futureApps = selectedFutureApps[namespace] || false;
 
-        const namespacePassesFilters = (!searchText || namespace.toLowerCase().includes(searchText)) && (!showSelectedOnly || !!selected.length);
+        const namespacePassesFilters = !searchText || namespace.toLowerCase().includes(searchText);
         if (!namespacePassesFilters) return null;
 
         const isNamespaceSelected = selectedNamespace === namespace && !selectAllForNamespace;
@@ -169,7 +169,7 @@ export const SourcesList: React.FC<Props> = ({
                           <Checkbox initialValue={isSourceSelected} onChange={() => onSelectSource(source, namespace)} />
                           <Text>{source.name}</Text>
                           <Text opacity={0.8} size={10}>
-                            {source.numberOfInstances} running instances · {source.kind}
+                            {source.numberOfInstances} running instance{source.numberOfInstances !== 1 && 's'} · {source.kind}
                           </Text>
                         </FlexRow>
                       </SourceItem>
diff --git a/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-simple/sources-list/index.tsx b/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-simple/sources-list/index.tsx
index 7bdc2fe65..9553cbfd7 100644
--- a/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-simple/sources-list/index.tsx
+++ b/frontend/webapp/containers/main/sources/choose-sources/choose-sources-body/choose-sources-body-simple/sources-list/index.tsx
@@ -108,7 +108,7 @@ export const SourcesList: React.FC<Props> = ({
               <TextWrapper>
                 <Text>{source.name}</Text>
                 <Text opacity={0.8} size={10}>
-                  {source.numberOfInstances} running instances · {source.kind}
+                  {source.numberOfInstances} running instance{source.numberOfInstances !== 1 && 's'} · {source.kind}
                 </Text>
               </TextWrapper>
             </ListItemContent>