Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starred Files #431

Closed
emmtte opened this issue Oct 12, 2015 · 16 comments
Closed

Starred Files #431

emmtte opened this issue Oct 12, 2015 · 16 comments
Assignees
Milestone

Comments

@emmtte
Copy link

emmtte commented Oct 12, 2015

Hello,
What's the command to download only the starred files?

@odeke-em
Copy link
Owner

Hello @ManuCart thanks for reporting this and welcome to drive!

Unfortunately the command to download only starred files hasn't yet been implemented, but it can be added.

@odeke-em odeke-em added this to the v0.3.2 milestone Oct 12, 2015
@odeke-em
Copy link
Owner

Please feel free if you'd like to contribute a PR as this week is kinda tricky for me with assignments and midterms but probably at the end of the week, if a PR hasn't been made.

@emmtte
Copy link
Author

emmtte commented Oct 12, 2015

Ok thanks for your answer. I'll be wait for this feature.

@odeke-em odeke-em modified the milestones: v0.3.3, v0.3.2 Oct 31, 2015
@emmtte
Copy link
Author

emmtte commented Oct 31, 2015

Oh,it's too bad for waiting v0.3.3, I really need this function

@odeke-em
Copy link
Owner

Oh my bad, I didn't realize this was much needed. The reason I've pushed this to the next release is because starred files appear to be in the root but actually need to have a reverse lookup for all their parents till we get back to the root. I had actually started working on this using a remote machine two weeks but had to run for a class then forgot about it, after logging off. I wish this had crossed my mind last night when I was whipping out drive code. So how about this, I get a week's break off from school starting on Friday 6th November 2015 and I make a promise to get it in as soon as am free :)

@odeke-em odeke-em self-assigned this Oct 31, 2015
@emmtte
Copy link
Author

emmtte commented Nov 1, 2015

Thanks very much, I know you give your best.

@odeke-em odeke-em mentioned this issue Nov 9, 2015
@odeke-em
Copy link
Owner

odeke-em commented Nov 9, 2015

Hello again @ManuCart,
Thank you very much for the patience. I've implemented this functionality in PR #467. Please get the latest from master and let me know how it goes.
Cheers!

@odeke-em
Copy link
Owner

odeke-em commented Nov 9, 2015

@ManuCart as a bonus I've added the ability to "star" or "unstar" files in PR #470, also present in master.

@emmtte
Copy link
Author

emmtte commented Nov 9, 2015

Hello,
Wonderful job, but the pull request with --starred arg still working only on the root folder

@odeke-em
Copy link
Owner

odeke-em commented Nov 9, 2015

Ah I see, yes it is relative to the current working directory like the other commands which is what I meant before by it being an awkward command because files appear in root but are in different places. The alternative would be for me to add an option '--all' that will be directory agnostic but will only be run from master. Unfortunately am away from home or a physical computer for the next 7 hours but will do so when I get home. Thanks

@odeke-em
Copy link
Owner

Hello @ManuCart, please get the latest from master PR #476 adds the ability to pull all the starred files (it is working directory agnostic), so this is a bonus feature as well as allowing for pulling starred files by matches and also relative to the current working directory.
Thanks again.

@emmtte
Copy link
Author

emmtte commented Nov 11, 2015

Thanks for all, it's working that I expected. Your script help me a lot.
Great job.

@emmtte emmtte closed this as completed Nov 11, 2015
@odeke-em
Copy link
Owner

Thank you very much for the patience, for raising this issue and for the kind words. Am glad to know that it has been addressed for you. Cheers!

@emmtte
Copy link
Author

emmtte commented Dec 7, 2015

I found a bug and it's a problem for me.
When a starred file is in trash and not empty trash
I do a request about starred files, the starred trash files are comming with the starred files.
Could you help me?

@emmtte emmtte reopened this Dec 7, 2015
@odeke-em
Copy link
Owner

odeke-em commented Dec 7, 2015

Could you open a separate issue and close this one, that's a broad scope for a feature request. That's a bug that can be fixed on its own. Thanks.

@emmtte
Copy link
Author

emmtte commented Dec 7, 2015

OK thanks

@emmtte emmtte closed this as completed Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants