Add option to specify sass implementation to use. #274
Conversation
jgerigmeyer
commented
Feb 22, 2024
jgerigmeyer
commented
| @@ -69,7 +69,7 @@ export type Parser = (rule: Rule, ctx: Context) => Parser; | |||
| export const runSass = function ( | |||
| trueOptions: TrueOptions, | |||
| src: string, | |||
| sassOptions?: Options<'sync'> | StringOptions<'sync'>, | |||
| sassOptions?: any, | |||
There was a problem hiding this comment.
This is unfortunate, but unavoidable if we really want to support any Sass implementation.
There was a problem hiding this comment.
I haven't tried it, but could you do something like Options<'sync'> | StringOptions<'sync'> | any? Not sure if that just removes any benefit anyways, though.
There was a problem hiding this comment.
If these weren't TypeScript types, that would work. But the problem is until runtime we don't know whether sass or sass-embedded (or some other future implementation?) is available, so we don't have a place we can safely import the Options and StringOptions types from.
There was a problem hiding this comment.
@mirisuzanne @jamesnw Okay, I think this is ready for review now.
| @@ -69,7 +69,7 @@ export type Parser = (rule: Rule, ctx: Context) => Parser; | |||
| export const runSass = function ( | |||
| trueOptions: TrueOptions, | |||
| src: string, | |||
| sassOptions?: Options<'sync'> | StringOptions<'sync'>, | |||
| sassOptions?: any, | |||
There was a problem hiding this comment.
I haven't tried it, but could you do something like Options<'sync'> | StringOptions<'sync'> | any? Not sure if that just removes any benefit anyways, though.
