Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customCSS url() rewriting is broken on Windows #265

Closed
rjgotten opened this issue Feb 28, 2018 · 3 comments
Closed

customCSS url() rewriting is broken on Windows #265

rjgotten opened this issue Feb 28, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@rjgotten
Copy link

URLs in customCSS that are rewritten, end up broken on Windows. The rewriting logic uses the path module, which uses \ as the separator on Windows and you end up with broken URLs.

@jgerigmeyer
Copy link
Member

Thanks! A PR (with tests) would be welcome; otherwise I'll try to get to this in the next week.

@jgerigmeyer
Copy link
Member

@rjgotten We're now running tests against a Windows environment, but I don't have a good way to functionally check that this is working in Windows. Would you be willing to try against the master branch and see if this is adequately fixed? Thanks!

@rjgotten
Copy link
Author

rjgotten commented Mar 28, 2018

@jgerigmeyer
This seems to be working OK now.
The paths are correctly rewritten.

When installing the master branch directly via npm install I have a bit of a problem though; seems the entire /assets/webpack folder is gone. So I cannot actually test the entire documentation in vivo.

Have to go off of what I can read when I open the custom css file in /assets/custom in my text editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants