Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify profile fitting API #47

Open
3 tasks
thclark opened this issue Feb 14, 2019 · 0 comments
Open
3 tasks

Unify profile fitting API #47

thclark opened this issue Feb 14, 2019 · 0 comments
Assignees
Labels
feature A new feature of the app

Comments

@thclark
Copy link
Contributor

thclark commented Feb 14, 2019

The function API for fit_power_law_speed passes parameters directly, and does not allow variation of u_ref as a parameter, instead simply fitting alpha.

  • Alter the cost residual to accept u_ref and z_ref as parameters. NB problem is underconstrained if you allow them both to vary, so ensure there's an assertion to allow only one of them (either fit alpha and u_ref, alpha alone, or alpha and z_ref).
  • Alter the API to accept an Array2d &initial_parameters and Array2b &fixed_parameters the same as the API for fit_lewkowiz_speed. It may be possible to generalise the cost functor used for fitting lewkowicz speed, to help keep code DRY.
  • Update docs and unit tests correspondingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature of the app
Projects
None yet
Development

No branches or pull requests

1 participant