Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AdemData to fully fledged class. #34

Open
6 tasks
thclark opened this issue Jan 18, 2019 · 1 comment
Open
6 tasks

Refactor AdemData to fully fledged class. #34

thclark opened this issue Jan 18, 2019 · 1 comment
Assignees

Comments

@thclark
Copy link
Contributor

thclark commented Jan 18, 2019

The AdemData class is currently treated as a struct, with a group of functions operating on it.

It's also header-only, which makes for one very long file.

In this refactor:

  • Make get_t2w a class method
  • Make get_mean_speed a class method
  • Make get_reylonds_stresses a class method
  • Make get_spectra a class method
  • Make function adem a class method, renaming it to something descriptive e.g. 'analyse'.
  • Move function bodies out to adem.cpp
@thclark
Copy link
Contributor Author

thclark commented Feb 27, 2019

Removing from AURA project backlog as too much work already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant