Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport improvements from @octokit-next #595

Merged
merged 1 commit into from
Nov 12, 2023
Merged

feat: backport improvements from @octokit-next #595

merged 1 commit into from
Nov 12, 2023

Conversation

wolfy1339
Copy link
Member

Backports some improvements from @octokit-next:

  • Simplify (flatten) the parameters
  • Add type support for 205 HTTP status code
  • Add types for the data parameter

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Backports some improvements from `@octokit-next`:

- Simplify (flatten) the parameters
- Add type support for 205 HTTP status code
- Add types for the `data` parameter
@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Nov 11, 2023
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thank you for that ❤️

@gr2m gr2m merged commit 0eebf54 into main Nov 12, 2023
7 checks passed
@gr2m gr2m deleted the backport-types branch November 12, 2023 17:32
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 12.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants