This repository has been archived by the owner on Jul 27, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 42
feat: 98 new operation IDs and respective deprecations #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
suggested changes
Jun 5, 2020
…resolves conflict with `GET /repos/:owner/:repo/comments/:commit_sha/comments`
…solves conflict with `GET /repos/:owner/:repo/comments/:commit_sha/comments`
…ential-authorizations`
…-saml-sso-authorization`
…-public-membership`
… `orgs/publicize-membership`
…tes `orgs/conceal-membership`
…ected-branch-admin-enforcement`
…te-review-comment-reply`
…iews/:review_id/comments`
gr2m
suggested changes
Jun 6, 2020
…ious operation IDs
gr2m
suggested changes
Jun 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repos/listCommentsForCommit
is renamed torepos/listCommitComments
repos/listCommitComments
is renamed tolistCommitCommentsForRepo
.
Problems is that a deprecation is not possible for repos/listCommitComments
. repos/listCommentsForCommit
must be renamed to something else to avoid the conflict.
Others
-
users/list-public-emails
is missing deprecation: it's nowusers/list-public-emails-for-authenticated
-
repos/get-protected-branch-restrictions
is missing deprecation. it's nowrepos/get-access-restrictions
gr2m
approved these changes
Jun 7, 2020
gr2m
changed the title
🤖📯 Octokit routes changed
feat: 98 new operation IDs and respective deprecations
Jun 7, 2020
🎉 This PR is included in version 29.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found new changes on https://developer.github.com/v3/ and thought I'd let you know about it 👋🤖
I can't tell if the changes are fixes, features or breaking, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.