Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT]: v20 uses deprecated API #471

Closed
1 task done
skelouse opened this issue Oct 27, 2024 · 4 comments
Closed
1 task done

[MAINT]: v20 uses deprecated API #471

skelouse opened this issue Oct 27, 2024 · 4 comments
Labels
Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@skelouse
Copy link

Describe the need

Deprecation: [@octokit/request-error] error.code is deprecated, use error.status.
Deprecation: [@octokit/request-error] error.headers is deprecated, use error.response.headers.

SDK Version

No response

API Version

20.1.1

Relevant log output

Deprecation: [@octokit/request-error] `error.code` is deprecated, use `error.status`.
Deprecation: [@octokit/request-error] `error.headers` is deprecated, use `error.response.headers`.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@skelouse skelouse added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Oct 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

This is known and fixed in v21

@wolfy1339 wolfy1339 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Oct 27, 2024
@skelouse
Copy link
Author

@wolfy1339

No CJS support on v21 https://github.com/orgs/octokit/discussions/68

@wolfy1339
Copy link
Member

The deprecated api is known in v20. It can't be fixed without breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfy1339 @skelouse