Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing file extension on bottleneck import #520

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Feb 26, 2024

Resolves #519


Before the change?

  • When importing the package, consumers get a ERR_MODULE_NOT_FOUND error from the bottleneck import

After the change?

  • When importing the package, no errors are thrown

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Feb 26, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m gr2m merged commit 0383322 into main Feb 26, 2024
8 checks passed
@gr2m gr2m deleted the fix-import branch February 26, 2024 04:16
Copy link

🎉 This PR is included in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Error ERR_MODULE_NOT_FOUND in v7
2 participants