Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated migration import endpoints and reorder bypass_actors.actor_type enum values to be in alphabetical order #731

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

octokitbot
Copy link
Collaborator

If there are any new endpoints, then the code changes will likely required an update of @octokit/types. It should have received a pull request as well, merge & release it first. The @octokit/types should be updated automatically shortly after in this pull request.

Make sure to update the commits so that the merge results in helpful release notes, see Merging the Pull Request & releasing a new version.

In general

  • Avoid breaking changes at all costs
  • If there are no typescript or code changes, use a docs prefix
  • If there are typescript changes but no code changes, use fix(typescript) prefix
  • If there are code changes, use fix if a problem was resolved, feat if new endpoints / parameters were added, and feat(deprecation) if a method was deprecated.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Apr 15, 2024
@kfcampbell kfcampbell changed the title 🚧 GitHub OpenAPI specifications changed feat: remove deprecated migration import endpoints and reorder bypass_actors.actor_type enum values to be in alphabetical order Apr 15, 2024
@wolfy1339
Copy link
Member

This one should be a breaking change as it removes an endpoint

@wolfy1339 wolfy1339 added the Type: Breaking change Used to note any change that requires a major version bump label Apr 15, 2024
@kfcampbell
Copy link
Member

Agreed! I went to see about merging octokit/openapi-types.ts#414 and then pulling those changes into here first, though I got a bit hung up because I'm not seeing the migration endpoint removal there.

@wolfy1339 wolfy1339 merged commit 85bf1df into main Apr 15, 2024
9 checks passed
@wolfy1339 wolfy1339 deleted the openapi-update branch April 15, 2024 22:13
Copy link
Contributor

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339
Copy link
Member

I think GitHub hasn't removed it from the OpenAPI spec just yet.

The endpoint isn't available anymore

Warning: Due to very low levels of usage and available alternatives, this endpoint is deprecated and will no longer be available from 00:00 UTC on April 12, 2024. For more details and alternatives, see the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants